Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ARM toolchains from get_mbed_official_release() #10398

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Projects
None yet
7 participants
@bridadan
Copy link
Contributor

commented Apr 12, 2019

Previously it would return ARM for ARMC5, which was quite confusing, since supplying -t ARM will select either ARMC5 or ARMC6 internally. Now it will return ARMC5 if the targets only supports ARMC5, ARMC5 and ARMC6 if it supports both, or just ARMC6 if it only supports ARMC6.

Description

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@OPpuolitaival - I'd like to double check with you that this won't cause issues or break assumptions in the CI

Release Notes

Make get_mbed_official_release return ARMC5 and ARMC6.
Previously it would return "ARM" for "ARMC5", which was quite confusing.

@ciarmcom ciarmcom requested review from OPpuolitaival and ARMmbed/mbed-os-maintainers Apr 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

@bridadan, thank you for your changes.
@OPpuolitaival @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@OPpuolitaival
Copy link
Contributor

left a comment

Looks great!

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@OPpuolitaival - I'd like to double check with you that this won't cause issues or break assumptions in the CI

As this is refactor, will go into 5.13 (let us know if this is not the case)

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 15, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 15, 2019

Test run: FAILED

Summary: 4 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

restarted CI

@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

This pr in its current form does break the current assumptions in the CI, which is why no targets were built with ARM toolchains.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

This pr in its current form does break the current assumptions in the CI, which is why no targets were built with ARM toolchains.

Will wait for CI update

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 15, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_greentea-test
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

CI updated.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

CI restarted (rebuild)

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 15, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

restarted jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Apr 16, 2019

@adbridge adbridge added needs: CI and removed needs: review labels Apr 25, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 25, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

@bridadan please take a look at the test failures

@bridadan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@adbridge looks like some uvision6 jobs timed out. Does that mean it needs to be restarted?

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

ci restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 26, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
@alekla01

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Restarted cloud-client-test

@adbridge adbridge added ready for merge and removed needs: CI labels Apr 29, 2019

@0xc0170 0xc0170 merged commit 39699d5 into ARMmbed:master Apr 29, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 9343 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.