Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: send disconnect to correct ctx #10402

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Projects
None yet
7 participants
@jarvte
Copy link
Contributor

commented Apr 15, 2019

Description

Disconnect was sent to all CellularContext classes even it concerned one specific context. Some disconnect events are still sent to all context classes. These event are coming from network and ment for all context classes or event did not specify cid.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

Release Notes

@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers Apr 15, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-wan Apr 15, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 16, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
Cellular: send disconnect to correct ctx
Disconnect was sent to all CellularContext classes even it concerned
one specific context. Some disconnect events are still sent to all
context classes. These event are coming from network and ment for all
context classes or event did not specify cid.

@jarvte jarvte force-pushed the jarvte:disconnect_per_context branch from 24d6246 to 9d67a8b Apr 17, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

rebased with master to resolve conficts

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Apr 17, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

ping

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@ARMmbed/mbed-os-maintainers could you please run CI for this pr? We need this for further development.

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 26, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@adbridge I guess failure is not related to this pr.

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

Failure looks like an ARMCC6 licence checkout issue - restarted

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@adbridge still failing with exporter

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

exporters restarted again

@0xc0170 0xc0170 merged commit 1ce073a into ARMmbed:master Apr 29, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8528 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@jarvte jarvte deleted the jarvte:disconnect_per_context branch Apr 29, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

This is sitting on top of changes targeting 5.13 so bumping this out also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.