Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings on PSA secure builds #10407

Merged
merged 1 commit into from Apr 18, 2019

Conversation

Projects
None yet
4 participants
@orenc17
Copy link
Contributor

commented Apr 15, 2019

Description

  • Add #include where needed
  • Cast where needed
  • Remove #include psa/service.h from NSPE in PSA tests

Fix most of the warnings from #10396

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170

Release Notes

@ciarmcom ciarmcom requested review from 0xc0170 and ARMmbed/mbed-os-maintainers Apr 15, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@orenc17, thank you for your changes.
@0xc0170 @ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 17, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Failures related, please fix

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Apr 17, 2019

@orenc17 orenc17 force-pushed the kfnta:warn_fix branch from a83d363 to f51eb62 Apr 17, 2019

@orenc17

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

Fixed and rebased

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 17, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 18, 2019

@0xc0170 0xc0170 merged commit ca887a9 into ARMmbed:master Apr 18, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8589 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.