Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments and improve readability for the BusInOut class #10408

Merged
merged 2 commits into from Apr 18, 2019

Conversation

Projects
None yet
4 participants
@sg-
Copy link
Member

commented Apr 15, 2019

Description

Improve the doxygen comments for BusInOut

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AnotherButler

@AnotherButler AnotherButler requested a review from kegilbert Apr 15, 2019

@AnotherButler
Copy link
Contributor

left a comment

Thanks for the PR 👍

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Please review spellcheck errors, there are two:

Errors: 
28: constucted
29: digitial
@AnotherButler

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

😲 Shocking.
Great catch, @0xc0170 👍

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 16, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
Fix typos in BusInOut.h
Fix typos.
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

CI started

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 18, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 18, 2019

@0xc0170 0xc0170 merged commit 8c69607 into ARMmbed:master Apr 18, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8524 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.