Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDPSOCKET_ECHOTEST fails if a packet of every size was not sent #10426

Merged
merged 1 commit into from Apr 26, 2019

Conversation

Projects
None yet
7 participants
@michalpasztamobica
Copy link
Contributor

commented Apr 17, 2019

Description

So far the UDPSOCKET_ECHOTEST could report success if no packets were sent. The only trace of problems was visible in the logs.
It could also report pass if the device was able to send a lot of small packets, but consistently failed with larger ones.
We want to make sure that at least one packet of every size gets sent at least once, so we check if the number of sent packets increased after every loop (it can increase by 1, 2 or 3, depending on how many times the retry loop executes.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@SeppoTakalo
@VeijoPesonen

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:udp_echo_error_handling branch from 34d3a42 to e3c9f3e Apr 17, 2019

@ciarmcom ciarmcom requested review from SeppoTakalo, VeijoPesonen and ARMmbed/mbed-os-maintainers Apr 17, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:udp_echo_error_handling branch from e3c9f3e to e11fade Apr 17, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 17, 2019

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

@0xc0170 , is there some CI issue or something wrong with my code or PR?

10:03:32 Scheduling project: mbed-os-ci_build-ARM
Aborted by Martin Kojtal

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

Aborted build, we need CI time for 5.12.2 jobs today. this needs reviews first - it was run by CI trigger, it's now disabled, need manual control for now.

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 17, 2019

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
@VeijoPesonen
Copy link
Contributor

left a comment

Should be mentioned also in the test specifications to avoid confusion

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:udp_echo_error_handling branch from e11fade to 46ee10f Apr 18, 2019

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:udp_echo_error_handling branch from 46ee10f to d1017ea Apr 18, 2019

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

@VeijoPesonen , I amended the documentation, including the sentence on recvfrom(), to express how the test really works.

@adbridge adbridge added needs: CI and removed needs: review labels Apr 25, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 25, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

The greentea failures are in K66F block storage tests.They are in no way related to my changes. I restarted the greentea job.

@michalpasztamobica

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

@SeppoTakalo , your review would be much appreciated :)

@adbridge adbridge merged commit a5f1a12 into ARMmbed:master Apr 26, 2019

19 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8618 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.