Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure UNO_91H to support PDMC compile #10449

Merged
merged 4 commits into from May 2, 2019

Conversation

Projects
None yet
8 participants
@fredlee12001
Copy link
Contributor

commented Apr 22, 2019

Description

1, Change target.json by add FLASHIAP, mbed address offsets etc. So that PDMC compile could pass on UNO_91H platform.
2, Add mbed APP address offset support for all 3 linker scripts.
3, UNO_91H have multi kind of flash size, add support for that by configure mbed_rom_size.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

Add configuration to support PDMC compile
Configurable flash size for UNO_91H
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

@fredlee12001, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Apr 22, 2019

fredlee12001 added some commits Apr 22, 2019

@bulislaw
Copy link
Member

left a comment

Looks good to me, @MarceloSalazar any thoughts?

@MarceloSalazar MarceloSalazar self-requested a review Apr 24, 2019

@MarceloSalazar
Copy link
Contributor

left a comment

@fredlee12001 thanks for the changes! These are very much needed to enable the bootloader and platform for Pelion support.
Approved, assuming all tests pass.

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

@fredlee12001 Please add a suitable description in the PR header.

@fredlee12001

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

PR description updated.

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

@fredlee12001 Many thanks :)

@adbridge adbridge added needs: CI and removed needs: review labels Apr 26, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Apr 26, 2019

ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 29, 2019

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

Please review build failures

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Apr 29, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

CI restarted

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Apr 30, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 30, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

A number of random iar exporter failures, possibly a licence issue so restarted

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 2, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented May 2, 2019

Test run: FAILED

Summary: 5 of 7 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-IAR
@alekla01

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

restarted jenkins-ci

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Ci restarted again

@mbed-ci

This comment has been minimized.

Copy link

commented May 2, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 5
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 2, 2019

@0xc0170 0xc0170 merged commit bb3fdac into ARMmbed:master May 2, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8592 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@0xc0170 0xc0170 removed the ready for merge label May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.