Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDP-K1: Updates to target code #10471

Merged
merged 4 commits into from May 2, 2019

Conversation

Projects
None yet
6 participants
@malavikasajikumar
Copy link
Contributor

commented Apr 24, 2019

Description

Improvements made to PinNames.h of SDP-K1 board.
AWAKE signal turned on at system init for SDP-K1 board.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@bulislaw

Release Notes

@malavikasajikumar malavikasajikumar referenced this pull request Apr 24, 2019

Closed

PinNames.h: #10460

@ciarmcom ciarmcom requested review from bulislaw and ARMmbed/mbed-os-maintainers Apr 25, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

@malavikasajikumar, thank you for your changes.
@bulislaw @ARMmbed/mbed-os-maintainers please review.

@bulislaw bulislaw changed the title Master SDP-K1: Updates to target code Apr 25, 2019

@bulislaw

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

Hi @malavikasajikumar thanks for that, one more thing could you remove the first two commits? First one introduces changes and second is reverting them

PinNames.h: d9de36a79723872a7ad386cc058722d89070443d
Revert "PinNames.h:" ffe74404f99f2d18499c6e32f0f1cb529e0bb937

You can do it easily using git rebase -i a3157e2 and removing two lines that list commits mentioned above, then you just force push it to your fork and the PR will be automatically refreshed.

malavikasajikumar added some commits Apr 24, 2019

Improvements made to PinNames.h of SDP-K1 board.
PinNames.h:
- Removing definition of Status LED.
- Redefining SPI and I2C pin names using Arduino pins names.
AWAKE signal turned on at system init for SDP-K1 board.
- Setting AWAKE signal high in the SystemInit() to ensure VIO supply to daughter boards through SDP and Arduino connectors.

@malavikasajikumar malavikasajikumar force-pushed the malavikasajikumar:master branch from eea637a to f11f63d Apr 26, 2019

@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

Hi @malavikasajikumar thanks for that, one more thing could you remove the first two commits? First one introduces changes and second is reverting them

PinNames.h: d9de36a79723872a7ad386cc058722d89070443d
Revert "PinNames.h:" ffe74404f99f2d18499c6e32f0f1cb529e0bb937

You can do it easily using git rebase -i a3157e2 and removing two lines that list commits mentioned above, then you just force push it to your fork and the PR will be automatically refreshed.

@bulislaw Thanks for the suggestion. Done. Let me know if any other changes are needed.

LED2 = PK_6, // Orange LED
LED3 = PK_5, // Green LED
LED_RED = LED1,
LED_ORANGE = LED2,

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Apr 29, 2019

Member

Please fix alignment in this file (LED_ORANGE aligned with LED_RED and others for instance)

This comment has been minimized.

Copy link
@malavikasajikumar

malavikasajikumar Apr 29, 2019

Author Contributor

Thanks, @0xc0170.
e0faeb2

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 29, 2019

@bulislaw
Copy link
Member

left a comment

LGTM

@0xc0170
Copy link
Member

left a comment

LGTM, just year change is not correct. As soon as updated, will go into CI

@@ -1,7 +1,7 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2019 ARM Limited
* Copyright (c) 2006-2017 ARM Limited

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Apr 30, 2019

Member

2019 as this one is being edited this year

@0xc0170

0xc0170 approved these changes May 2, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: work labels May 2, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 2, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 2, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-ARM
  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
@alekla01

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

restarted jenkins-ci

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Ci restarted again

@mbed-ci

This comment has been minimized.

Copy link

commented May 2, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 2, 2019

@0xc0170 0xc0170 merged commit 87711a9 into ARMmbed:master May 2, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8555 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@0xc0170 0xc0170 removed the ready for merge label May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.