Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ADC pins mapping for FRMD-K66F (#10498) #10506

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
6 participants
@JarekParal
Copy link
Contributor

commented Apr 29, 2019

Description

Add the missing configuration for ADC pins (PTB4, PTB5) for FRDM-K66F board to PeripheralNames.h and PeripheralPins.c.

Solve in issue #10498.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom ciarmcom requested review from maclobdell, MarceloSalazar and ARMmbed/mbed-os-maintainers Apr 29, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

@JarekParal, thank you for your changes.
@MarceloSalazar @maclobdell @ARMmbed/mbed-os-maintainers please review.

@@ -44,6 +44,8 @@ const PinMap PinMap_ADC[] = {
{PTC9, ADC1_SE5b, 0},
{PTC10, ADC1_SE6b, 0},
{PTC11, ADC1_SE7b, 0},
{PTB4 , ADC1_SE10, 0},

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Apr 29, 2019

Member

Small fix needed - code alignment - pins should be aligned

This comment has been minimized.

Copy link
@JarekParal

JarekParal Apr 29, 2019

Author Contributor

Sorry I have a different setting of my code editor. Fix in bd59a4c.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Apr 29, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Apr 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Apr 30, 2019

@0xc0170 0xc0170 merged commit a5862df into ARMmbed:master Apr 30, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8607 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.