Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing support of FLASHIAP in general_filesystem tests #10523

Merged
merged 1 commit into from May 13, 2019

Conversation

Projects
None yet
6 participants
@yossi2le
Copy link
Contributor

commented May 2, 2019

Description

Even so, FlashIAP block device was supported in the general_filesystem test, it was actually skipped. However, the static initialization of the filesystem cause problems in some cases and fail.
Because there is no logic of having all tests skipped and also there are only rare cases which justify supporting of a functional filesystem in an internal flash, I have removed all support of FLASHIAP from the test.

This solve issue #10264

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers May 2, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 2, 2019

@yossi2le, thank you for your changes.
@ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@0xc0170

0xc0170 approved these changes May 2, 2019

@davidsaada
Copy link
Contributor

left a comment

LGTM.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 2, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 7, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 12, 2019

Test restarted (the failures were for not related changes and accross all devices, looks like CI error rather).

@0xc0170 0xc0170 merged commit f65e30e into ARMmbed:master May 13, 2019

19 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8559 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.