Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvoton: Add COMPONENT_FLASHIAP support #10527

Merged
merged 1 commit into from May 12, 2019

Conversation

Projects
None yet
5 participants
@ccli8
Copy link
Contributor

commented May 3, 2019

Description

Some Nuvoton targets support DEVICE_FLASH but its related COMPONENT_FLASHIAP support is not enabled. This PR enables it on these targets:

  • NUMAKER_PFM_M453
  • NUMAKER_PFM_M2351

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
Nuvoton: Add COMPONENT_FLASHIAP support
Some Nuvoton targets support DEVICE_FLASH but their corresponding COMPONENT_FLASHIAP
supports are not enabled. Enable them:

NUMAKER_PFM_M453
NUMAKER_PFM_M2351

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers May 3, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 3, 2019

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Travis failures are known problem (not related to this PR, will be affecting any PR at the moment)

@0xc0170

0xc0170 approved these changes May 3, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 3, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 7, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 7, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_mbed2-build-GCC_ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 10, 2019

CI restarted (internal CI failure)

@mbed-ci

This comment has been minimized.

Copy link

commented May 10, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit f8cedf3 into ARMmbed:master May 12, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8513 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_flashiap_component branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.