Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Increase receiving timeout for UDP echo non-blocking test #10543

Merged

Conversation

Projects
None yet
5 participants
@mirelachirica
Copy link
Contributor

commented May 8, 2019

Description

This is similar to PR #10184 that incresed the timeout from 1s to 2s. The 2 seconds timeout still seems unstable -> increased to 5 seconds

WISE-1570 is passing the UDPSOCKET_ECHOTEST_NONBLOCK only with a greater receiving timeout.

Note: UDPSOCKET_ECHOTEST_BURST_NONBLOCK on the other hand would pass even with a receiving timeout of 1 sec. I think the UDPSOCKET_ECHOTEST_NONBLOCK can be improved so that receiving timeout of 1 sec would be enough for this test too. I will create an issue about this to the test responsable team.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change
Cellular: WISE-1570 needs greater receiving timeout to pass UDPSOCKET…
…_ECHOTEST_NONBLOCK test

Reason for needing greater timeout could be this test's performance.
UDPSOCKET_ECHOTEST_BURST_NONBLOCK is implementing the receiving
differently and is passing with 1 second timeout.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers May 8, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 8, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 13, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 13, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 13, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 2239bab into ARMmbed:master May 13, 2019

19 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8515 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.