Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: fixed compile warnings from cellular #10554

Merged
merged 1 commit into from May 17, 2019

Conversation

Projects
None yet
7 participants
@jarvte
Copy link
Contributor

commented May 10, 2019

Description

Removed compile warnings from cellular to clean up the compile.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mirelachirica

Release Notes

@ciarmcom ciarmcom requested review from mirelachirica and ARMmbed/mbed-os-maintainers May 10, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 10, 2019

@jarvte, thank you for your changes.
@mirelachirica @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Member

left a comment

Fine as it is, for future reference: It would be helpful to provide what warnings are being fixed

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 13, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 13, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Please review build failures, related to these changes

@0xc0170 0xc0170 added needs: work and removed needs: CI labels May 13, 2019

@jarvte jarvte force-pushed the jarvte:remove_compile_warnings branch from 24b1a9f to d56c8ca May 14, 2019

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

amended compile error fixes

@adbridge adbridge added needs: CI and removed needs: work labels May 16, 2019

@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 16, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented May 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 3
Build artifacts

@adbridge adbridge added ready for merge and removed needs: CI labels May 17, 2019

@adbridge adbridge merged commit 25019df into ARMmbed:master May 17, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8617 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

There is something strange, conflict wise, with both this and the related #10557 and neither will patch across to 5.12. Thus bumping to 5.13.

@jarvte jarvte deleted the jarvte:remove_compile_warnings branch May 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.