Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: fix CCC callback not being called when writing to a CCC #10575

Merged
merged 2 commits into from May 15, 2019

Conversation

Projects
None yet
7 participants
@paul-szczepanek-arm
Copy link
Member

commented May 14, 2019

Description

When creating a CCC manually the special handling of the attribute creation for CCC would set the correct CCC flag but then normal handling would also include the normal handling causing the setting for writable enabling the write callback which takes precedence. This fix removes that callback thus allowing the CCC callback to happen.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@paul-szczepanek-arm

This comment has been minimized.

Copy link
Member Author

commented May 14, 2019

@cy-kishore please comment

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers May 14, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@paul-szczepanek-arm, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@cy-kishore

This comment has been minimized.

Copy link

commented May 15, 2019

Hi,
After this fix, for explicit ccc descriptor when a client does read or write to cccd which application callback gets called? will onUpdatesEnabled and onUpdatesDisabled callbacks get called?

@0xc0170 0xc0170 requested a review from ARMmbed/team-cypress May 15, 2019

@cy-kishore

This comment has been minimized.

Copy link

commented May 15, 2019

Hi,
We have verified our use case with this fix and it is working. Please merge the same.

@pan-

pan- approved these changes May 15, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented May 15, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge added ready for merge and removed needs: CI labels May 15, 2019

@adbridge adbridge merged commit 8e44a75 into ARMmbed:master May 15, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8647 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.