Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LED4 definition in PinNames.h of SDP-K1 board. #10582

Merged
merged 3 commits into from May 23, 2019

Conversation

Projects
None yet
5 participants
@malavikasajikumar
Copy link
Contributor

commented May 14, 2019

Description

Adding LED4 definition in PinNames.h of SDP-K1 board.
Removed stale pin definitions.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers May 14, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@malavikasajikumar, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

SPI_MISO = D12,
SPI_SCK = D13,
I2C_SDA = D14,
I2C_SCL = D15,

This comment has been minimized.

Copy link
@0xc0170

0xc0170 May 15, 2019

Member

Why is this being removed? Dxx can still be used, this is just having SPI/I2C pins as well .

This comment has been minimized.

Copy link
@malavikasajikumar

malavikasajikumar May 17, 2019

Author Contributor

This change was intended and the lines are being removed so that only the Arduino connector pin names (D0-D15) are used in example programs for this board. This is to ensure code portability to other Mbed enabled boards with Arduino form factor.
@0xc0170 @adbridge

This comment has been minimized.

Copy link
@malavikasajikumar

malavikasajikumar May 20, 2019

Author Contributor

Hello, can this code be merged? Is there a reason to keep those lines of code, though we have reasons to have them removed?
@0xc0170 @adbridge @bentcooke

This comment has been minimized.

Copy link
@0xc0170

0xc0170 May 21, 2019

Member

This should be OK, it will work - any program using Dxx will function. I recall we have this SPI_/I2C_ pin names defined for almost every board, not certain how this would be different

@MarceloSalazar @jamesbeyond Can you review?

This comment has been minimized.

Copy link
@0xc0170

0xc0170 May 21, 2019

Member

Better compatibility would be with these lines left in here

This comment has been minimized.

Copy link
@malavikasajikumar

malavikasajikumar May 21, 2019

Author Contributor

@0xc0170 That commit has been removed. Please merge the file. We need at least rest of the changes to be released.
The pin names issue can be resolved later.

@0xc0170 0xc0170 self-requested a review May 15, 2019

@adbridge adbridge added needs: work and removed needs: review labels May 17, 2019

@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

@0xc0170 @bentcooke
Hi, when is the next mbed-os release?

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 21, 2019

5.13.0 is the next one

@0xc0170 0xc0170 requested review from MarceloSalazar and ARMmbed/mbed-os-hal May 21, 2019

@malavikasajikumar malavikasajikumar force-pushed the malavikasajikumar:master branch from 4ba7a96 to d5b84a5 May 21, 2019

@malavikasajikumar

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

@0xc0170 Please approve. Thank you.

#10582 (comment)

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 23, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 23, 2019

@0xc0170 0xc0170 merged commit 02b91bd into ARMmbed:master May 23, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8570 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.