Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GR_LYCHEE,RZ_A1H,VK_RZ_A1H: Fix greentea test failure with ARMC6 #10587

Merged
merged 2 commits into from May 21, 2019

Conversation

Projects
None yet
6 participants
@d-kato
Copy link
Contributor

commented May 16, 2019

Description

Fix for issue #10356

The FPU register was used before __FPU_Enable() was called in SystemInit(). So I fixed the call timing of __ FPU_Enable().

To resolve this issue, in addition to this change, the following changes need to be merged: ARM-software/CMSIS_5@3f3b67f

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@toyowata

Release Notes

@d-kato

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

The CMSIS_5 changes need to be merged. Should I wait for CMSIS_5 changes to be merged into mbed-os? Or should I do cherry-pick for this PR?

@toyowata toyowata requested review from toyowata and cmonr May 16, 2019

@toyowata
Copy link
Contributor

left a comment

LGTM

@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

@toyowata Please note Cruz (@cmonr ) is no longer working on mbed-os. Please tag mbed-os-maintainers if they are not already tagged instead.

@adbridge

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

The CMSIS_5 changes need to be merged. Should I wait for CMSIS_5 changes to be merged into mbed-os? Or should I do cherry-pick for this PR?

@d-kato We definitely do not want to be adding CMSIS changes to this PR. I will mark this PR as needing a preceeding PR.

@adbridge adbridge removed the request for review from cmonr May 16, 2019

@adbridge adbridge added needs: CI and removed needs: review labels May 16, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@d-kato Can you import ARM-software/CMSIS_5@3f3b67f to the Mbed OS ?

@d-kato

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

@0xc0170 Does it mean to add to this PR using cherry-pick? If so it is possible.

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 21, 2019

@0xc0170 Does it mean to add to this PR using cherry-pick? If so it is possible.

@kjbracey-arm would that be OK, and we import latest version for 5.13 later this week?

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 21, 2019

@d-kato please cherry pick required commit here, will start CI

Core(A): Fixed __FPU_Enable function not to mess registers. (#589)
- Enhanced function to use only two temporary registers.
- Added used registers to clobber list.

Change-Id: If7c9462ed4424781e40379fbe12a5e4e3257920f
@d-kato

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

@0xc0170 I added ARM-software/CMSIS_5@3f3b67f to this PR. Please confirm.

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 21, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 21, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 3e1a24b into ARMmbed:master May 21, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8720 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.