Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Semaphore::acquire methods #10596

Merged
merged 1 commit into from May 29, 2019

Conversation

Projects
None yet
7 participants
@kjbracey-arm
Copy link
Contributor

commented May 16, 2019

Deprecate wait() in favour of acquire(), try_acquire(), try_acquire_for() and try_acquire_until().

Brings Semaphore more into line with CMSIS-RTOS 2 (which uses "acquire"), itself (as it has "release"), and other classes having "try", "try for" and "try until".

Also steps away from vague "wait" term - the primary operation here is to acquire the semaphore, and this will of course sleep.

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@bulislaw

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

This PR follows on from #10104, and I mentioned it in discussion there - I regard it as part of the same naming tidy-up. Only the one commit is new in this PR, the rest are just #10104.

@ciarmcom ciarmcom requested review from bulislaw and ARMmbed/mbed-os-maintainers May 16, 2019

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:sem_acquire branch from 236389d to efe62ea May 17, 2019

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:sem_acquire branch 6 times, most recently from 7922d07 to 53995bd May 17, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 23, 2019

CI started (to get first check done)

@mbed-ci

This comment has been minimized.

Copy link

commented May 23, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:sem_acquire branch 2 times, most recently from 8528cb2 to 11804b3 May 23, 2019

@0xc0170 0xc0170 removed the needs: review label May 24, 2019

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:sem_acquire branch 2 times, most recently from 7a2dc19 to cd6e345 May 24, 2019

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:sem_acquire branch from cd6e345 to 5eff9a2 May 24, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: work labels May 24, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 24, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented May 24, 2019

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 26, 2019

unittests still need fixing

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:sem_acquire branch from 5eff9a2 to 4ae42a6 May 27, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 27, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented May 27, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:sem_acquire branch from 4ae42a6 to 0fa7b0b May 27, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented May 27, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 5
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:sem_acquire branch from 0fa7b0b to ad27be1 May 27, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented May 27, 2019

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 6
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:sem_acquire branch from ad27be1 to effba58 May 27, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented May 27, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 7
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_greentea-test
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Semaphore test timeouted.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:sem_acquire branch from effba58 to 9b40700 May 28, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented May 28, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 8
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
Introduce Semaphore::acquire methods
Deprecate wait() in favour of acquire(), try_acquire(),
try_acquire_for() and try_acquire_until().

Brings Semaphore more into line with CMSIS-RTOS 2 (which uses "acquire"),
itself (as it has "release"), and other classes having "try", "try for"
and "try until".

Also steps away from vague "wait" term - the primary operation here is
to acquire the semaphore, and this will of course sleep.

@kjbracey-arm kjbracey-arm force-pushed the kjbracey-arm:sem_acquire branch from 9b40700 to 2fbbd9d May 28, 2019

@cmonr

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

CI restarted. Something with status reporting to the PR was stuck.

@mbed-ci

This comment has been minimized.

Copy link

commented May 28, 2019

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 9
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
@0xc0170

This comment has been minimized.

Copy link
Member

commented May 28, 2019

CI internal error , restarted

@mbed-ci

This comment has been minimized.

Copy link

commented May 29, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 10
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 29, 2019

@0xc0170 0xc0170 merged commit 9cc1caa into ARMmbed:master May 29, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8683 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.