Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wi-Sun certificate options to mesh api configuration json #10598

Merged
merged 2 commits into from May 21, 2019

Conversation

Projects
None yet
7 participants
@mikaleppanen
Copy link
Contributor

commented May 16, 2019

Description

Add possibility to configure Wi-Sun root certificate, own certificate
and own certificate keys to mesh api.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mikter

Added Wi-Sun certificate options to mesh api configuration json
Added possibility to configure Wi-Sun root certificate, own certificate
and own certificate keys to mesh api.

@ciarmcom ciarmcom requested review from mikter and ARMmbed/mbed-os-maintainers May 16, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 16, 2019

@mikaleppanen, thank you for your changes.
@mikter @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@@ -153,6 +153,22 @@
"wisun-uc-dwell-interval": {
"help": "Unicast dwell interval. Range: 15-255 milliseconds",
"value": 0
},
"certificate-header": {
"help": "Certificate header",

This comment has been minimized.

Copy link
@SeppoTakalo

SeppoTakalo May 16, 2019

Contributor

What is the type or range of the value field? Please document that as well.

Others have already documentation.

This comment has been minimized.

Copy link
@mikaleppanen

mikaleppanen May 17, 2019

Author Contributor

Corrected

arm_certificate_chain_entry_s chain_info;
memset(&chain_info, 0, sizeof(arm_certificate_chain_entry_s));
chain_info.cert_chain[0] = (const uint8_t *) MBED_CONF_MBED_MESH_API_ROOT_CERTIFICATE;
chain_info.cert_len[0] = strlen((const char *) MBED_CONF_MBED_MESH_API_ROOT_CERTIFICATE) + 1;

This comment has been minimized.

Copy link
@artokin

artokin May 16, 2019

Contributor

Could you check configuration validity at compile time to avoid hard fault caused by illegal configuration?

This comment has been minimized.

Copy link
@mikaleppanen

mikaleppanen May 17, 2019

Author Contributor

Check added

@mikaleppanen

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

@artokin @SeppoTakalo Updated pull request according to comments.

@mikter

mikter approved these changes May 20, 2019

@0xc0170 0xc0170 changed the title Added Wi-Sun certificate options to mesh api configuration json Add Wi-Sun certificate options to mesh api configuration json May 20, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 20, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 20, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 20, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 21, 2019

@0xc0170 0xc0170 merged commit 5f36041 into ARMmbed:master May 21, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8571 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.