Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K66F: Update SAI and SAI EDMA driver to SDK 2.5 #10605

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
5 participants
@sabharad
Copy link
Contributor

commented May 17, 2019

Description

SAI and SAI EDMA drivers in SDK 2.2 does not work with demo EDMA based audio loopback code from SDK 2.5. Tested the changes locally to confirm that updating SAI and SAI EDMA driver to SDK 2.5 fixes the issue. Driver code for SDK 2.5 was downloaded from https://mcuxpresso.nxp.com

Pull request type

[X ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@mmahadevan108

@ciarmcom ciarmcom requested review from maclobdell, MarceloSalazar and ARMmbed/mbed-os-maintainers May 17, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 17, 2019

@sabharad, thank you for your changes.
@MarceloSalazar @maclobdell @ARMmbed/mbed-os-maintainers please review.

@mmahadevan108
Copy link
Contributor

left a comment

@sabharad Thank you for your changes.

@mmahadevan108

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

@sabharad I am curious about your use-case. Can you share some details.

@sabharad

This comment has been minimized.

Copy link
Contributor Author

commented May 19, 2019

@mmahadevan108 The use case is to receive 16-bit 16 kHz mono audio from the DA7212 codec using I2S through EDMA. For some reason, SDK 2.2 drivers in mbed didn't work with SAI EDMA demo/example code from SDK 2.5.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels May 20, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 20, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 20, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage

@0xc0170 0xc0170 merged commit e4c6422 into ARMmbed:master May 21, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8616 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.