Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: fix unit test valgrind warnings #10623

Merged
merged 1 commit into from May 22, 2019

Conversation

Projects
None yet
6 participants
@jarvte
Copy link
Contributor

commented May 21, 2019

Description

Fix unit test Valgrind warnings.
Stub files did have some memory leaks and using uninitialized variables.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

Release Notes

Cellular: fix unit test valgrind warnings
Stub files did have some memory leaks and using
unintialized variables.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers May 21, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 21, 2019

@jarvte, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 22, 2019

CI started

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 22, 2019

@0xc0170 0xc0170 merged commit 516a214 into ARMmbed:master May 22, 2019

15 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8747 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@jarvte jarvte deleted the jarvte:fix_cellular_valgrind_ut branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.