Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: deprecate UARTService and suppress compiler warnings #10635

Merged
merged 2 commits into from May 23, 2019

Conversation

Projects
None yet
6 participants
@LDong-Arm
Copy link
Contributor

commented May 22, 2019

Description

Deprecated BLE APIs called by deprecated services

We have already marked a few services (e.g. ones for Beacon) as deprecated, thus their uses of deprecated API should not lead to more compiler warnings.

UARTService

UARTService uses the old GAP advertising API which is now deprecated in favour of AdvertisingDataBuilder.
After discussing with @pan- @paul-szczepanek-arm, we consider deprecating UARTService.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan- @paul-szczepanek-arm

Deprecate UARTService
UARTService is rarely used and has not been actively updated.

@LDong-Arm LDong-Arm force-pushed the LDong-Arm:deprecated_ble_services branch from 8f7188b to d10ec03 May 22, 2019

@ciarmcom ciarmcom requested review from pan-, paul-szczepanek-arm and ARMmbed/mbed-os-maintainers May 22, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 22, 2019

@pan-
Copy link
Member

left a comment

The changes looks good however could you prefix Deprecated.h with its folder: ble/pal/Deprecated.h ?

@LDong-Arm

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

The changes looks good however could you prefix Deprecated.h with its folder: ble/pal/Deprecated.h ?

Thanks, will do

Suppress warnings of deprecated API in deprecated services
Services that already have deprecation notices in place should
not trigger more warnings from the compiler.

@LDong-Arm LDong-Arm force-pushed the LDong-Arm:deprecated_ble_services branch from d10ec03 to f3c29df May 23, 2019

@0xc0170
Copy link
Member

left a comment

Deprecating, no replacement ?

@pan-

This comment has been minimized.

Copy link
Member

commented May 23, 2019

@0xc0170 This service hasn't been maintained for a long time (more than three years) and never really worked due to architectural defects (there's no flow control and we don't know when data flows out). I believe it is better to deprecate it now rather than leave the false impression it is useful and safe to use. It was a bad decision to land this code in the OS in the first place.

@pan-

pan- approved these changes May 23, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 23, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 23, 2019

@0xc0170 0xc0170 merged commit 3801d4a into ARMmbed:master May 23, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8635 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.