Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+UPSND sent to poll activation status #10636

Merged
merged 4 commits into from May 23, 2019

Conversation

Projects
None yet
5 participants
@bqam-ublox
Copy link
Contributor

commented May 22, 2019

Description

This pull request updates the context activation using the +UPSND AT command. Previously, the context status was updated immediately after activating the context (without verifying if it was activated successfully).

+UPSND command responds with the status of the context activation. The status is polled every 5s with a max timeout of 180s.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 22, 2019

@bqam-ublox, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Member

left a comment

Please fix coding style (see Travis failures)

@0xc0170 0xc0170 added needs: work and removed needs: review labels May 23, 2019

@bqam-ublox

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

@0xc0170 coding style fixed

@@ -192,14 +191,29 @@ bool UBLOX_AT_CellularContext::activate_profile(const char *apn,
if (_at.get_last_error() == NSAPI_ERROR_OK) {
// Activate, wait upto 30 seconds for the connection to be made
_at.set_at_timeout(30000);
_at.cmd_start("AT+UPSDA=0,3");
_at.cmd_start("AT+UPSD=" PROFILE ",6,");

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila May 23, 2019

Contributor

Could you check UPSDA is dismissed here intentionally?

This comment has been minimized.

Copy link
@bqam-ublox

bqam-ublox May 23, 2019

Author Contributor

This was a mistake! Thanks for pointing out, corrected.

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 23, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels May 23, 2019

@0xc0170 0xc0170 merged commit 4567626 into ARMmbed:master May 23, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8706 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@bqam-ublox bqam-ublox deleted the u-blox:activation_status branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.