Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation notice for ble::Gap::getState() #10646

Merged
merged 1 commit into from May 24, 2019

Conversation

Projects
None yet
6 participants
@LDong-Arm
Copy link
Contributor

commented May 23, 2019

Description

The deprecation notice suggests getConnectionCount() which did not land in the final API.

The proper replacement of getState().connected is keeping a local record in the application and updating it during connection and disconnection callbacks.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@pan- @paul-szczepanek-arm

Fix deprecation notice for ble::Gap::getState()
The deprecation notice suggests getConnectionCount() which
did not land in the final API. The proper replacement is keeping
your own record and updating during connection and disconnection
callbacks.

@ciarmcom ciarmcom requested review from pan-, paul-szczepanek-arm and ARMmbed/mbed-os-maintainers May 23, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 23, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 23, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@pan-

pan- approved these changes May 24, 2019

@0xc0170 0xc0170 merged commit c4cc9c4 into ARMmbed:master May 24, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Success
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 9599 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@LDong-Arm LDong-Arm deleted the LDong-Arm:connectionCount branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.