Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USBHostMSD: Implement BlockDevice get_type() #10654

Merged
merged 1 commit into from Jun 4, 2019
Merged

USBHostMSD: Implement BlockDevice get_type() #10654

merged 1 commit into from Jun 4, 2019

Conversation

desowin
Copy link
Contributor

@desowin desowin commented May 24, 2019

Description

This makes it possible to create instances of USBHostMSD class.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@desowin
USBHostMSD: Implement BlockDevice get_type()
3116f32 
This makes it possible to create instances of USBHostMSD class.
@ciarmcom ciarmcom requested a review from a team May 24, 2019 11:00
@ciarmcom
Copy link
Member

@desowin, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

maciejbocianski
maciejbocianski approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@maciejbocianski maciejbocianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@0xc0170
Copy link
Contributor

0xc0170 commented May 31, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented May 31, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@desowin desowin mentioned this pull request Jun 3, 2019
Closed
@0xc0170 0xc0170 merged commit 04d0b0d into ARMmbed:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maciejbocianski maciejbocianski maciejbocianski approved these changes

Assignees
No one assigned
Labels
release-version: 5.13.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@desowin @ciarmcom @0xc0170 @mbed-ci @maciejbocianski @adbridge