Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export wait_ns to be overridable #10683

Merged
merged 1 commit into from Jun 3, 2019

Conversation

@ccli8
Copy link
Contributor

commented May 28, 2019

Description

This PR is replacement for #10632. Some targets may not provide zero-wait-state flash performance. Export wait_ns to be overridable for targets to provide more accurate implementation like locating delay_loop_code in SRAM.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kjbracey-arm

Some targets may not provide zero-wait-state flash performance. Export this function
to be overridable for targets to provide more accurate implementation like locating
'delay_loop_code' in SRAM.
@kjbracey-arm

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

Still would like to see M2351's cache enabled so this wasn't necessary (for it) though.

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 31, 2019

I've just noticed nightly failures for this:

| NUMAKER_PFM_M487-ARMC6 | NUMAKER_PFM_M487 | tests-mbed_platform-wait_ns                                                  | FAIL   | 41.21              | default     |

This PR should fix it, shouldn't it?

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Wait, it only provides a hook, not the real fix.

@0xc0170

This comment has been minimized.

Copy link
Member

commented May 31, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented May 31, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit a93542b into ARMmbed:master Jun 3, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage Internal error, will be fixed
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8605 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170 0xc0170 removed the ready for merge label Jun 3, 2019
@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_wait-ns_weak branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.