Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MbedCRC: make buffers const void * #10699

Merged
merged 2 commits into from Jun 9, 2019

Conversation

@gpsimenos
Copy link
Contributor

commented May 29, 2019

Description

In MbedCRC, changing the following buffers from void * to const void *:
int32_t compute(const void *buffer, crc_data_size_t size, uint32_t *crc)
int32_t compute_partial(const void *buffer, crc_data_size_t size, uint32_t *crc)

This addresses issue #8287 (IOTCORE-556)

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@gpsimenos

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

My first PR to Mbed OS as a member of the Core & Platform team, testing the waters. Let me know if I missed anything, as we had a different process before in Update Client.

@40Grit

This comment has been minimized.

Copy link

commented May 29, 2019

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers May 29, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@gpsimenos, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-core May 29, 2019
@0xc0170
0xc0170 approved these changes Jun 3, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 7, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 8, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit a1fab9d into ARMmbed:master Jun 9, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(-63949 bytes) RAM(-33162 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8555 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170 0xc0170 removed the ready for merge label Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.