Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal_qspi_test: undo buggy code #10755

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
4 participants
@maciejbocianski
Copy link
Member

commented Jun 4, 2019

Removes buggy code introduced to hal_qspi_test by PR #10435
in commit:
Added support for QSPI to Cypress Boards a8570ff

This PR Fixes following issues:
#10730
#10728

@cy-opm could you retest Cypress Boards with these changes

Description

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@0xc0170
@cy-opm

Release Notes

hal_qspi_test: undo buggy code
Remove some buggy code introduced to hal_qspi_test by PR #10435
Added support for QSPI to Cypress Boards
a8570ff
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Is this partial revert ? Changes touching the tests are being reverted here?

@maciejbocianski

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2019

Yes it's partial, but rest of changes looks OK.
It adds extra testcases for 1I4O write mode

@0xc0170

0xc0170 approved these changes Jun 4, 2019

Copy link
Member

left a comment

The new addition will need to be properly added this time 🙄

@jeromecoutant
Copy link
Contributor

left a comment

target platform_name test suite result elapsed_time (sec) copy_method
DISCO_L475VG_IOT01A-ARMC6 DISCO_L475VG_IOT01A tests-mbed_hal-qspi OK 36.92 default
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Ci started

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 4, 2019

Test run: FAILED

Summary: 3 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

CI restarted , it was aborted

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 4, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@maciejbocianski

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2019

Strange fail on EV_COG_AD3029LZ IAR looks not related, cannot even determine the reason
@0xc0170 can we restart CI ?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

yes, will do

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 5, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

Nightly QSPI should be fixed !

@0xc0170 0xc0170 merged commit 2b354a4 into ARMmbed:master Jun 5, 2019

19 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8530 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@0xc0170 0xc0170 removed the ready for merge label Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.