Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARMC5 compilation #10805

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
8 participants
@kjbracey-arm
Copy link
Contributor

commented Jun 11, 2019

Description

Minor tweaks to fix ARM C 5 compatibility.

Pushing "ns_list.h" include to first makes sure "ns_types.h" is included
first, meaning it gets to define __STDC_LIMIT_MACROS before the first
include of <stdint.h>, which ensures that UINT8_MAX etc are defined.

Fixes #10789

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@TeroJaasko

Fix ARMC5 compilation
Minor tweaks to fix ARM C 5 compatibility.

Pushing "ns_list.h" include to first makes sure "ns_types.h" is included
first, meaning it gets to define `__STDC_LIMIT_MACROS` before the first
include of <stdint.h>, which ensures that UINT8_MAX etc are defined.
@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

Tested ARM C 5 blinky compilation locally for K64F.

@ciarmcom ciarmcom requested review from TeroJaasko and ARMmbed/mbed-os-maintainers Jun 11, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@adbridge
Copy link
Contributor

left a comment

LGTM

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

Started ci while awaiting additional reviews

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 11, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 11, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge added ready for merge and removed needs: CI labels Jun 11, 2019

@adbridge adbridge merged commit fc645bc into ARMmbed:master Jun 11, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(-44255 bytes) RAM(+7603 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8557 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@TeroJaasko

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

This fixes blinky, which is great, but one more fix is needed for ns_list.h for NS_LIST_HEAD_BY_OFFSET_() to build the Pelion cloud client.

@kjbracey-arm kjbracey-arm deleted the kjbracey-arm:armc5_blinky branch Jun 11, 2019

@kjbracey-arm

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

New fix in #10809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.