Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stmod_cellular component #10866

Merged
merged 2 commits into from Jun 24, 2019

Conversation

@LMESTM
Copy link
Contributor

commented Jun 19, 2019

Description

stmod_cellular component library adds up support for cellular modem that
are connected to the STMOD+ connector.

Currently supported modems are BG96 and UG96.

Support is fully derived from BG96 and UG96 support from cellular framework, mainly soft power on and off sequences are adapted here.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ x] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@MarceloSalazar @AnttiKauppila

Release Notes

This library allows enabling the cellular module that is connected to the STMOD+ connector of the board.

Currently supported cellular modules are Quectel UG96 and BG96 expansion boards that are included in [p-l496g-cell01] (https://www.st.com/en/evaluation-tools/p-l496g-cell01.html) and [p-l496g-cell02.] (https://www.st.com/en/evaluation-tools/p-l496g-cell02.html) packs.

The STMOD+ Connector specification can be found [here] (https://www.st.com/content/ccc/resource/technical/document/technical_note/group0/04/7f/90/c1/ad/54/46/1f/DM00323609/files/DM00323609.pdf/jcr:content/translations/en.DM00323609.pdf).

stmod_cellular component library adds up support for cellular modem that
are connected to the STMOD+ connector.

Currently supported modems are BG96 and UG96.
@jeromecoutant

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

@MarceloSalazar

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

@LMESTM thanks for the PR. This looks good from my point of view
@AnttiKauppila @ARMmbed/mbed-os-maintainers please review

@ciarmcom ciarmcom requested review from AnttiKauppila, MarceloSalazar and ARMmbed/mbed-os-maintainers Jun 19, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

@LMESTM, thank you for your changes.
@AnttiKauppila @MarceloSalazar @ARMmbed/mbed-os-maintainers please review.

@MarceloSalazar

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

@ARMmbed/mbed-os-maintainers please review and comment whether we're ready to merge

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

@ARMmbed/mbed-os-maintainers please review and comment whether we're ready to merge

This needs a review from the cellular team before it progresses

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

@ARMmbed/mbed-os-maintainers please review and comment whether we're ready to merge

This needs a review from the cellular team before it progresses

Ahh hadn't noticed that the bot had wiped out Antti's approval.

@adbridge

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 23, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
@LMESTM

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

@adbridge can you help explaining the CI failure ?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

There was an issue with CI slaves, restarted 2 jobs

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

All green, ready for merge

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 24, 2019
@0xc0170 0xc0170 merged commit f2a7408 into ARMmbed:master Jun 24, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+4488 bytes) RAM(+17104 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8597 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.