Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Remove IPV6 and IPV4V6 as supported properties for BG96 #10875

Merged
merged 1 commit into from Jun 24, 2019

Conversation

Projects
None yet
6 participants
@mirelachirica
Copy link
Contributor

commented Jun 20, 2019

Description

Need to revert part of what was introduced by: 3e6f5eb

Reason being:
IPV6 and IPV6V4 support is also network dependent not only modem.

Having these properties enabled for a modem requires a fallback mechanism during PDP context activation, so that if IPV6 context fails to activate it should be tried activating an IPV4 context. This mechanism is missing at the moment and that can result in impossibility to establish successful connection when network only supports IPV4 contexts.

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
Cellular: Remove IPV6 and IPV4V6 as supported properties for BG96
IPV6 and IPV6V4 support is also network dependent not only modem.

Having these properties enabled for a modem requires a fallback
mechanism during PDP context activation. This mechanism is missing
at the moment and that can result in imposibility to establish
succesfull connection when network only supports IPV4 contexts.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jun 20, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

@mirelachirica, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@mbed-ci

This comment has been minimized.

Copy link

commented Jun 24, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jun 24, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

jenkins-ci/dynamic-memory-usage — RTOS ROM(-44279 bytes) RAM(+7595 bytes)

We will investigate these numbers reported here . Not related to this PR.

@0xc0170 0xc0170 merged commit 979f26f into ARMmbed:master Jun 24, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(-44279 bytes) RAM(+7595 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8528 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.