Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Ublox cellular context activation updated for C030_R412M #10877

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@mudassar-ublox
Copy link
Contributor

commented Jun 20, 2019

Description

UBLOX_C030_R412M cellular context activation updated for 2G. Updated RAT and AUTH configuration and other minor fixes.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jun 20, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

@mudassar-ublox, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@mudassar-ublox mudassar-ublox force-pushed the u-blox:ubx_context_activation branch from 782617b to 8851238 Jun 21, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

Please fix astyle

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jun 28, 2019
@mudassar-ublox mudassar-ublox force-pushed the u-blox:ubx_context_activation branch from 8851238 to dd568a6 Jul 9, 2019
@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

Astyle issue fixed and update PR as well, updated RAT and AUTH configurations. Please review.

@artokin

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@mudassar-ublox , would you please resolve the conflicts?

@mudassar-ublox mudassar-ublox force-pushed the u-blox:ubx_context_activation branch from dd568a6 to a9f7909 Jul 9, 2019
@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@mudassar-ublox , would you please resolve the conflicts?

Conflict resolved.

@@ -155,6 +155,11 @@ static void test_other()
{
TEST_ASSERT(nw->get_3gpp_error() == 0);

#ifdef TARGET_UBLOX_C030
nsapi_error_t err = nw->detach();

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Jul 9, 2019

Member

test should not contain #ifdef target, either works or not - handling this should be in the target code or driver.

This comment has been minimized.

Copy link
@mudassar-ublox

mudassar-ublox Jul 9, 2019

Author Contributor

Removed target specific code.

This comment has been minimized.

Copy link
@0xc0170

0xc0170 Jul 9, 2019

Member

will it work (test pass) ?

This comment has been minimized.

Copy link
@mudassar-ublox

mudassar-ublox Jul 10, 2019

Author Contributor

Yes, handled in driver, return UNSUPPORTED if try to change RAT while in attach state.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

@ARMmbed/mbed-os-wan Please review

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

Please review astyle failures

@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Please review astyle failures

Please review, Astyle issue fixed. AriParkkila once shared asytle software for styling and I used that for styling. Seems its not correct software for it as now getting style issue on my PR's.
Also attaching cellular tests result logs.
R412M_Cellular_Test.txt

@0xc0170

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

@mudassar-ublox use astylerc as config for astyle, it has all needed

@mudassar-ublox mudassar-ublox force-pushed the u-blox:ubx_context_activation branch from 1f9dae7 to 1ec6117 Jul 11, 2019
@wajahat-ublox

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

@mudassar-ublox This fixes #9711 correct?

@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

@mudassar-ublox This fixes #9711 correct?

Not sure about this issue but now we can set auth type from main application, set_authentication_type. Let me ask on ticket #9711.

@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

Anything else required on this PR?

@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

@0xc0170 any update on this PR?

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

@mudassar-ublox Please don't merge from master into your branch. Makes review and history really annoying.
Please remove the merge commit and rebase your branch on top of master.

@mudassar-ublox mudassar-ublox force-pushed the u-blox:ubx_context_activation branch from e20b269 to ee3e8e6 Jul 24, 2019
@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Issue fixed and re-based branch to latest master. Please review now.

@mudassar-ublox mudassar-ublox force-pushed the u-blox:ubx_context_activation branch from ee3e8e6 to ae4edde Jul 26, 2019
@SeppoTakalo SeppoTakalo added needs: CI and removed needs: work labels Jul 26, 2019
@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

Thanks.
CI tests started now.

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 26, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

@mudassar-ublox Please check the build failures

2019-07-26T08:11:22.017Z] [2019-07-26T08:11:22.017Z] [Warning] UBLOX_AT_CellularNetwork.cpp@101,13: 'wait_ms' is deprecated: 'wait_ms' is deprecated in favor of explicit sleep functions. To sleep, 'wait_ms' should be replaced by 'ThisThread::sleep_for' (C++) or 'thread_sleep_for' (C). If you wish to wait (without sleeping), call 'wait_us'. 'wait_us' is safe to call from ISR context. [since mbed-os-5.14] [-Wdeprecated-declarations]

[2019-07-26T08:11:22.017Z] [2019-07-26T08:11:22.017Z] Compile [ 10.9%]: UBLOX_PPP.cpp

[2019-07-26T08:11:22.017Z] [2019-07-26T08:11:22.017Z] Compile [ 11.0%]: sn_coap_builder.c

[2019-07-26T08:11:22.017Z] [2019-07-26T08:11:22.017Z] Compile [ 11.1%]: sn_coap_protocol.c

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.017Z] Compile [ 11.3%]: UBLOX_N2XX.cpp

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.018Z] Compile [ 11.4%]: UBLOX_AT_CellularStack.cpp

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.018Z] Compile [ 11.5%]: stoip4.c

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.018Z] Compile [ 11.6%]: UBLOX_AT_CellularContext.cpp

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.018Z] [Error] UBLOX_AT_CellularContext.cpp@87,22: use of undeclared identifier 'define_context'

[2019-07-26T08:11:22.018Z] [2019-07-26T08:11:22.018Z] Failed to build library
@SeppoTakalo SeppoTakalo added needs: work and removed needs: CI labels Jul 29, 2019
@mudassar-ublox mudassar-ublox force-pushed the u-blox:ubx_context_activation branch from ae4edde to 6cd6017 Jul 30, 2019
@mudassar-ublox

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

@SeppoTakalo Build failure fixed. Please review now.

@SeppoTakalo SeppoTakalo added needs: CI and removed needs: work labels Aug 1, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 1, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 4a1f00a into ARMmbed:master Aug 2, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8555 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Moving to 5.14 due to conflicts in cellular framework files . If needed earlier, PR for 5.13 branch that we could cherry pick would be good if needed earlier.
I tried to manually resolved but did not manage to get the changes from master from this changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.