Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPGA SPI: remove 4 and 12 bits size support #11009

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@jeromecoutant
Copy link
Contributor

commented Jul 9, 2019

Description

As it seems there is no device using this 4 and 12 size, proposition is to remove test ?

Thx

@LMESTM @c1728p9 @MarceloSalazar @ithinuel

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@ithinuel

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Some targets such as the MK66F from NXP do support symbols from 4 to 16bits ( https://www.nxp.com/docs/en/reference-manual/K66P144M180SF5RMV2.pdf#d5667e5a1310_d11e7876 ).
The upcoming SPI api has a capability structure to declare what size are supported.

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Jul 9, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

@mprse
mprse approved these changes Jul 10, 2019
Copy link
Member

left a comment

We do not have detailed requirements for the old SPI API which would strictly specify the defined behavior. Please consider this test as an example which shows some capabilities of the FPGA-Test-Shield.

On SPI feature branch (https://github.com/ARMmbed/mbed-os/tree/feature-hal-spec-spi) more expanded SPI test can be found.

I think that we can remove these cases, but please remove them permanently.

Copy link
Member

left a comment

I think that we can remove these cases, but please remove them permanently.

+1, we got git to revert back if needed, no need to keep "dead" code

@0xc0170 0xc0170 added needs: work and removed needs: review labels Jul 10, 2019
@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_SPI4 branch from 4a34aed to ef845c8 Jul 10, 2019
@jeromecoutant

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

Dead code removed.

Seems that the revert of this PR should come in the SPI feature branch!

@jeromecoutant

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

Can you start CI ?

@jamesbeyond

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

CI Started

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 18, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo dismissed 0xc0170’s stale review Aug 5, 2019

Test removed, dismissing the review.

@SeppoTakalo SeppoTakalo merged commit fb7bbd2 into ARMmbed:master Aug 5, 2019
19 checks passed
19 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8597 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_SPI4 branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.