Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvoton: Modify wait ns(...) to provide more accurate implementation #11019

Merged
merged 3 commits into from Jul 17, 2019

Conversation

@ccli8
Copy link
Contributor

commented Jul 11, 2019

Description

This PR modifies wait_ns(...) for Nuvoton targets:

  • For NUMAKER_PFM_M2351 NS, already locating on SRAM, refine wait_ns(...) to synchronize to common version.
  • For NUMAKER_PFM_NANO130/NUMAKER_PFM_NUC472, locate wait_ns(...) to SRAM from flash because flash code performance cannot achieve zero-wait state without cache support.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
ccli8 added 3 commits Jul 8, 2019
1.  Add missing header file for mbed_mpu_manager_lock_ram_execution()/
    mbed_mpu_manager_unlock_ram_execution() to avoid compile warning.
2.  Locate delay_loop_code() on 16-byte boundary (sync to common version).
3.  Optimize delay_loop macro (sync to common version).
NANO100 series doesn't support cache and so cannot provide zero-wait state
flash performance.
NUC472 series doesn't support cache but supports branch buffer. But it still
cannot provide zero-wait state flash performance.
@0xc0170 0xc0170 requested a review from kjbracey-arm Jul 11, 2019
@artokin artokin added needs: CI and removed needs: review labels Jul 15, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Jul 15, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 02f8fbd into ARMmbed:master Jul 17, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8533 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_wait-ns branch Jul 18, 2019
@ccli8

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

@SeppoTakalo One thing to note. This PR relies on #10683 which is targeted for 5.14.0. Correct the release version?

@evedon

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

Indeed, the target should have been 5.14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.