Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the GPIO HAL API tests #11038

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@fkjagodzinski
Copy link
Member

commented Jul 12, 2019

Description

Use the MbedTester to verify the functions from https://github.com/ARMmbed/mbed-os/blob/master/hal/gpio_api.h.

Updated tests:

  • tests-mbed_hal_fpga_ci_test_shield-gpio.

NOTE This patch won't work without a gpio_pinmap() function added in #10644.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@jamesbeyond @mprse @maciejbocianski

Release Notes

@ciarmcom ciarmcom requested review from jamesbeyond, maciejbocianski, mprse and ARMmbed/mbed-os-maintainers Jul 12, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

@fkjagodzinski

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

#10644 is merged now; this PR ready to proceed.

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

@ARMmbed/mbed-os-hal Please review.

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 17, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo removed the needs: CI label Jul 17, 2019
Copy link
Contributor

left a comment

LGTM

@SeppoTakalo SeppoTakalo merged commit c5c7458 into ARMmbed:master Jul 24, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8548 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@fkjagodzinski fkjagodzinski deleted the fkjagodzinski:fpga_test-gpio branch Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.