Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CC3220SF_Launchxl to Mbed OS #11063

Merged
merged 6 commits into from Aug 19, 2019

Conversation

@linlingao
Copy link
Contributor

commented Jul 17, 2019

Description

Add CC3220SF Launchxl support.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jul 17, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

@linlingao, thank you for your changes.
@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-storage please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-storage Jul 17, 2019

@SeppoTakalo SeppoTakalo requested a review from ARMmbed/mbed-os-hal Jul 17, 2019

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

New target support, @ARMmbed/mbed-os-hal Please review.

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 23, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

@linlingao Please check the build failures.

CC3220SF ARM

[2019-07-23T11:47:20.590Z] [2019-07-23T11:47:20.590Z] Compile [  0.1%]: at24mac_s2lp.cpp

[2019-07-23T11:47:20.590Z] [2019-07-23T11:47:20.590Z] [Fatal Error] at24mac_s2lp.h@19,10: 'PinNames.h' file not found

[2019-07-23T11:47:20.590Z] [2019-07-23T11:47:20.590Z] Failed to build library

CC3220SF_LAUNCHXL ARM

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z] Build failures:

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]   * CC3220SF_LAUNCHXL::ARMC6::TESTS-MBED_HAL-PINMAP

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Building project pinmap (CC3220SF_LAUNCHXL, ARMC6)

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Scan: ARM

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Scan: pinmap

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Compile [100.0%]: main.cpp

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Link: pinmap

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Warning] @0,0: L3912W: Option 'legacyalign' is deprecated.

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Warning] @0,0: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Warning] @0,0: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol analogin_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol pwmout_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol serial_cts_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol serial_rts_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol serial_rx_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol serial_tx_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol spi_master_clk_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol spi_master_cs_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol spi_master_miso_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         [Error] @0,0: L6218E: Undefined symbol spi_master_mosi_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Warning: L3912W: Option 'legacyalign' is deprecated.

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Warning: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Warning: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol analogin_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol pwmout_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol serial_cts_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol serial_rts_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol serial_rx_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol serial_tx_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.664Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol spi_master_clk_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.665Z] [2019-07-23T11:47:18.664Z]         Error: L6218E: Undefined symbol spi_master_cs_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.665Z] [2019-07-23T11:47:18.665Z]         Error: L6218E: Undefined symbol spi_master_miso_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.665Z] [2019-07-23T11:47:18.665Z]         Error: L6218E: Undefined symbol spi_master_mosi_pinmap (referred from BUILD/tests/CC3220SF_LAUNCHXL/ARM/TESTS/mbed_hal/pinmap/TESTS/mbed_hal/pinmap/main.o).

[2019-07-23T11:47:18.665Z] [2019-07-23T11:47:18.665Z]         Finished: 0 information, 3 warning and 10 error messages.

[2019-07-23T11:47:18.665Z] [2019-07-23T11:47:18.665Z]         
@mbed-ci

This comment has been minimized.

Copy link

commented Jul 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@fkjagodzinski
Copy link
Member

left a comment

Most of the HAL looks fine. Only the PWM is not complete.

targets/targets.json Show resolved Hide resolved
@mbed-ci

This comment has been minimized.

Copy link

commented Jul 30, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
@mbed-ci

This comment has been minimized.

Copy link

commented Jul 31, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
@cmonr

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

@ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-test-team That's odd.

Has it typically been the case where mbed-os-ci_cloud-client-test artifacts are not uploaded to S3, similar to the rest of the jobs?

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

One server that Pelion Client tests against is down. We are investigating.

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 1, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 5
Build artifacts

@SeppoTakalo SeppoTakalo removed the needs: CI label Aug 2, 2019

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

@ARMmbed/mbed-os-hal Missing PWM is now added, is this OK to go in?

@linlingao

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Please, please don't let this sit for too long... rebase PRs this big is painful...

@linlingao

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

@ARMmbed/mbed-os-hal can you please review?

@linlingao

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

@0xc0170 Is there anything I can do to move this along?

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@0xc0170 Is there anything I can do to move this along?

I keep this open and review tomorrow 👍

@0xc0170
Copy link
Member

left a comment

Cosmetic changes request. Otherwise looks good.

Lot of work in here, how was this tested? Adding new target should contain logs with tests run for all toolchains.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Aug 14, 2019

@linlingao

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@0xc0170 You can find status and links to Jira issues and test logs here. https://confluence.arm.com/display/CES/TI+Port+Milestones+and+Status (Arm internal link).

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 16, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 7
Build artifacts

@linlingao

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

Can this be merged yet?

@0xc0170 0xc0170 removed the needs: work label Aug 19, 2019

@0xc0170 0xc0170 merged commit 101ae73 into ARMmbed:master Aug 19, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8673 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.