Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSOC6: USB device implementation #11071

Merged
merged 2 commits into from Jul 29, 2019

Conversation

@cypress-neil
Copy link
Contributor

commented Jul 18, 2019

Description

This PR adds the PSOC6 USB files which were separated from #10692 (see #10692 (comment) ).

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

@cypress-neil, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jul 18, 2019

@cypress-neil cypress-neil marked this pull request as ready for review Jul 19, 2019

@bulislaw

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

@ARMmbed/team-cypress please review. Also @cypress-neil could you upload the test results for the usb subsystem please.

@SeppoTakalo SeppoTakalo requested a review from ARMmbed/team-cypress Jul 22, 2019

@SeppoTakalo SeppoTakalo requested a review from ARMmbed/mbed-os-hal Jul 23, 2019

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

@ARMmbed/mbed-os-hal Please review the proposed API. This USBPhyHw is quite generic name, but only provided by this one platform. Review if this is OK. Thanks.

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 23, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

Build failures:

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z] + tail -n 100 mbed-os-greentea_FUTURE_SEQUANA_ARM.log

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Building project hid (FUTURE_SEQUANA, ARMC6)

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Scan: ARM

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Scan: hid

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Compile [100.0%]: main.cpp

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         [Warning] main.cpp@41,9: 'MSG_KEY_DEVICE_READY' macro redefined [-Wmacro-redefined]

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Link: hid

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         [Warning] @0,0: L3912W: Option 'legacyalign' is deprecated.

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         [Warning] @0,0: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         [Warning] @0,0: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         [Error] @0,0: L6218E: Undefined symbol get_usb_phy() (referred from BUILD/tests/FUTURE_SEQUANA/ARM/TESTS/usb_device/hid/TESTS/usb_device/hid/main.o).

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Warning: L3912W: Option 'legacyalign' is deprecated.

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Warning: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Warning: L9931W: Your license for feature compiler5 will expire in 8 days

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Error: L6218E: Undefined symbol get_usb_phy() (referred from BUILD/tests/FUTURE_SEQUANA/ARM/TESTS/usb_device/hid/TESTS/usb_device/hid/main.o).

[2019-07-23T11:07:09.576Z] [2019-07-23T11:07:09.576Z]         Finished: 0 information, 3 warning and 1 error messages.
@svozcy

This comment has been minimized.

Copy link

commented Jul 23, 2019

@cypress-neil , it appears that targets.json enables USB Device for PSoC6 and FUTURE_SEQUANA what is not correct. The FUTURE_SEQUANA target must be updated because it does not support USB.

@fkjagodzinski
Copy link
Member

left a comment

Looks good to me.

@fkjagodzinski

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

@ARMmbed/mbed-os-hal Please review the proposed API. This USBPhyHw is quite generic name, but only provided by this one platform. Review if this is OK. Thanks.

@SeppoTakalo, this is fine, and actually follows our template (same as other tartgets) https://github.com/ARMmbed/mbed-os/blob/master/usb/device/targets/TARGET_Template/USBPhyHw.h

@SeppoTakalo SeppoTakalo added needs: CI and removed needs: work labels Jul 26, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 26, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 9affeb8 into ARMmbed:master Jul 29, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8755 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.