Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32L4: update drivers version to CUBE V1.14.0 #11072

Merged

Conversation

@jeromecoutant
Copy link
Contributor

commented Jul 19, 2019

Description

ST Cube drivers version is updated from V1.11.0 to V1.14.0,
which is the latest official version from:
https://www.st.com/en/embedded-software/stm32cubel4.html

ST CI tests OK

This fixes analogic tests.

@ARMmbed/team-st-mcd

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jul 19, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@SeppoTakalo SeppoTakalo requested a review from ARMmbed/team-st-mcd Jul 22, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Jul 22, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo removed the needs: CI label Jul 23, 2019
@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

@ARMmbed/team-st-mcd Please review. Otherwise this is good to go in.

@0xc0170 0xc0170 merged commit 9b43736 into ARMmbed:master Aug 9, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8599 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

I moved this to 5.14 due to the conflicts with 5.13 branch. If needed in 5.13, please send separate PR to 5.13 release branch where we can cherry-pick and add it to the next patch release.

I tried to resolve them manually but not sure f4 file showed in conflict resolution (confusing).

@jeromecoutant jeromecoutant deleted the jeromecoutant:PULL_REQUEST_CUBE_UPDATE_L4_V1.14.0 branch Aug 19, 2019
@danirex

This comment has been minimized.

Copy link

commented Aug 27, 2019

Not sure where to ask this, but it seems that USBDEVICE support was removed from the device I'm working on, NUCLEO_L4R5ZI. Was this intentional? I've tried adding it myself but it leads to compilation issues. Thanks

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

@danirex You better use questions: https://os.mbed.com/questions/

@danirex

This comment has been minimized.

Copy link

commented Aug 27, 2019

Thanks, will do.

@bulislaw

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@ARMmbed/team-st-mcd @MarceloSalazar @0xc0170 hi guys, this PR removed USB support for bunch of devices. I missed that during the review. That's actually a big problem for some of our partners. Was that a mistake can it be rectified ASAP (in 5.14 time scale).

@0xc0170

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Reviewing again targets.json, it was also reformatted. @jeromecoutant was this unintentional that some device_has were removed ? I could find there at least 2x USB removal.

My assumption - this was removed by mistake as this is just a driver update.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

I gathered all USB removals from targets.json and commited on my branch, it can be viewed here https://github.com/ARMmbed/mbed-os/compare/master...0xc0170:fix_usb_st_removal?expand=1

@ithinuel ithinuel referenced this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.