Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVStore.cpp (and KVStore) - run-time failure handling missing #11084

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@mtomczykmobica
Copy link
Contributor

commented Jul 22, 2019

Description

Against to using MBED_ASSERT (works only for DEBUG build, not working with release build) implemented valid failure handling for NVStore nad KVStore.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@JanneKiiskila
@SeppoTakalo

Release Notes

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

@mtomczykmobica Please review & fix those Astyle errors!

@ciarmcom ciarmcom requested review from JanneKiiskila, SeppoTakalo and ARMmbed/mbed-os-maintainers Jul 22, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

@mtomczykmobica mtomczykmobica force-pushed the mtomczykmobica:IOTSTOR-832 branch from ed0bb39 to 6cdb8f0 Jul 22, 2019
@mtomczykmobica

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

astyle fixed

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 22, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

Changed to "functionality change" because if you change ASSERTS() to runtime checks, then it changes the functionality.
So, cannot be pushed into patch release.

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 23, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 0b8ae1b into ARMmbed:master Jul 23, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8615 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.