Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new features to Toshiba's TMPM46B #11118

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@ganesh-ramachandran
Copy link
Contributor

commented Jul 29, 2019

Description

Add new features to Toshiba's TMPM46B

  • SPISlave
  • SPI_ASYNCH
  • I2CSlave
  • I2C_ASYNCH
  • RTC

Tested with all 3 toolchains and attached test logs:
M46B_ARM_TestResults.txt
M46B_GCC_ARM_TestResults.txt
M46B_IAR_TestResults.txt

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jul 29, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

@ganesh-ramachandran, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Ganesh Ramachandran Ganesh Ramachandran

@ganesh-ramachandran ganesh-ramachandran force-pushed the ganesh-ramachandran:m46b_newfeatures branch from a15a1f5 to edf36fb Aug 16, 2019

@0xc0170
Copy link
Member

left a comment

Ideally, features would be in each commit separately. For future reference, it would be better

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 20, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 20, 2019

@0xc0170 0xc0170 merged commit b16aaca into ARMmbed:master Aug 20, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8681 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@ganesh-ramachandran ganesh-ramachandran deleted the ganesh-ramachandran:m46b_newfeatures branch Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.