Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRF52 need to call TIMER_TASK_SHUTDOWN for current consumption #11123

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@desmond-blue
Copy link
Contributor

commented Jul 30, 2019

Description

Since current consumption increased when the timer has been running and only the STOP task is used to stop on nRF52x, we need to call SHUTDOWN task after STOP task.

reference for nRF52840
reference for nRF52832

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@40Grit

This comment has been minimized.

Copy link

commented Jul 30, 2019

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jul 30, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

@desmond-blue, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@bulislaw

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Thanks @desmond-blue,
have you run the ticker tests on the boards after the change?

@desmond-blue

This comment has been minimized.

Copy link
Contributor Author

commented Aug 2, 2019

@bulislaw I only ran the ticker/timer tests on nRF52840_DK, which is all I have. Could we access CI and run our own test job?

@bulislaw

This comment has been minimized.

Copy link
Member

commented Aug 2, 2019

I don't think we have this board in the CI at this stage. But your testing sounds like it should do for now.

@bulislaw
Copy link
Member

left a comment

LGTM @linlingao fyi

@SeppoTakalo SeppoTakalo added needs: CI and removed needs: review labels Aug 5, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 5, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 6436f11 into ARMmbed:master Aug 6, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8678 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.