Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated testcases #11130

Merged
merged 4 commits into from Aug 2, 2019

Conversation

@Tharazi97
Copy link
Contributor

commented Jul 31, 2019

Description

Fixes #9687
Changed testcases to look like this template:

#if !CONDITION
#error [NOT_SUPPORTED] This test requires CONDITION
#else
#include "CONDITION_or_something.h"
...
testcases
...
#endif // CONDITION

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@fkjagodzinski @maciejbocianski @deepikabhavnani @jamesbeyond, @SeppoTakalo

@ciarmcom ciarmcom requested review from deepikabhavnani, fkjagodzinski, jamesbeyond, maciejbocianski, SeppoTakalo and ARMmbed/mbed-os-maintainers Jul 31, 2019

Tharazi97 added 2 commits Jul 31, 2019
@bulislaw

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

Looks good, @jamesbeyond please review.

@@ -357,3 +357,4 @@ int main()
return !Harness::run(specification);
}

#endif // !DEVICE_USTICKER

This comment has been minimized.

Copy link
@SeppoTakalo

SeppoTakalo Jul 31, 2019

Contributor

Missing newlines at the end of files. (Probably all of them).

Some tools or compilers complain about this.

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 31, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo
Copy link
Contributor

left a comment

LGTM.

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 1, 2019

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 2
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 818c1d6 into ARMmbed:master Aug 2, 2019

19 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8594 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.