Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUTURE_SEQUANA: Add missing serial_free() implementation #11131

Merged
merged 1 commit into from Aug 5, 2019

Conversation

@lrusinowicz
Copy link
Contributor

commented Jul 31, 2019

Description

This PR adds missing serial_free() implementation to Sequana HAL implementation.
Should fix #11057; test logs attached.

tests_sequana_gcc_20190731.log

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Jul 31, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

@lrusinowicz, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@SeppoTakalo SeppoTakalo requested a review from ARMmbed/team-cypress Jul 31, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Jul 31, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-test
@lrusinowicz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

* jenkins-ci/mbed-os-ci_cloud-client-test

Looking into build artifacts I do not see any failures. So what's the issue?

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

One server that Pelion Client tests against is down. We are investigating.

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 1, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@SeppoTakalo SeppoTakalo removed the needs: CI label Aug 2, 2019

@SeppoTakalo SeppoTakalo merged commit f2236d2 into ARMmbed:master Aug 5, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8675 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.