Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement queue.count() #11145

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@Tharazi97
Copy link
Contributor

commented Aug 1, 2019

Description

Implements queue.count() which returns amount of items in the queue. As it is asked in: #10535

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[x] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@Terryvanderjagt @maciejbocianski @jamesbeyond @0xc0170 @mprse

Release Notes

@ciarmcom ciarmcom requested review from 0xc0170, jamesbeyond, maciejbocianski, mprse and ARMmbed/mbed-os-maintainers Aug 1, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@Tharazi97 Tharazi97 force-pushed the Tharazi97:CountFunctionQueue branch from 1b7df63 to 4ce0bb1 Aug 1, 2019
@mprse
mprse approved these changes Aug 1, 2019
Copy link
Member

left a comment

Looks good!

@@ -107,6 +107,17 @@ class Queue : private mbed::NonCopyable<Queue<T, queue_sz> > {
return osMessageQueueGetSpace(_id) == 0;
}

/** Check the quantity of items in queue.

This comment has been minimized.

Copy link
@evedon

evedon Aug 1, 2019

Contributor

It is not really a check. To be more precise, you could write:
"Get number of queued messages in the queue"
and
@return Number of items in the queue

@Tharazi97 Tharazi97 force-pushed the Tharazi97:CountFunctionQueue branch from 4ce0bb1 to 32bdde5 Aug 2, 2019
@evedon
evedon approved these changes Aug 2, 2019
@evedon

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

@Tharazi97 Please mark this code change as functionality change and docs update.

@SeppoTakalo SeppoTakalo added needs: CI and removed needs: review labels Aug 5, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 5, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 34813ed into ARMmbed:master Aug 6, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8691 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.