Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Remove unnecessary local variables #11149

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@mirelachirica
Copy link
Contributor

commented Aug 1, 2019

Description

Removes unnecessary local variables.

Pull request type

[ ] Fix
[*] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

strncpy(pdp_type_str, "Non-IP", sizeof(pdp_type_str));
pdp_type = NON_IP_PDP_TYPE;
} else if (modem_supports_ipv6 && modem_supports_ipv4) {
} else if (get_property(PROPERTY_IPV4V6_PDP_TYPE)) {

This comment has been minimized.

Copy link
@AriParkkila

AriParkkila Aug 1, 2019

Contributor

I guess it's good to add here that IPV4V6, but should also be IPV4 & IPV6 for single stack support.

This comment has been minimized.

Copy link
@mirelachirica

mirelachirica Aug 2, 2019

Author Contributor

If a target doesn't mark as supported the IPV4V6 feature but it has IPV4 and IPV6 support, I think we should consider it as it doesnt support IPV4V6. Why else wouldnt have it set accordingly?

@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers Aug 1, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

@SeppoTakalo SeppoTakalo added needs: CI and removed needs: review labels Aug 5, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 5, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@SeppoTakalo SeppoTakalo merged commit dd2d585 into ARMmbed:master Aug 6, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8630 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.