Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS servers from cellular PDP to nsapi #11162

Merged
merged 2 commits into from Aug 7, 2019

Conversation

@AriParkkila
Copy link
Contributor

commented Aug 5, 2019

Description

Add DNS servers from PDP contexts to nsapi_dns. Also fix nsapi_dns_add_server to add each server just once.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@kivaisan

Release Notes

@ciarmcom ciarmcom requested review from kivaisan and ARMmbed/mbed-os-maintainers Aug 5, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@AriParkkila AriParkkila force-pushed the AriParkkila:cell-dns branch from 9e67d44 to c6acced Aug 5, 2019

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

@kivaisan Please re-review.

@SeppoTakalo SeppoTakalo added needs: CI and removed needs: review labels Aug 5, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 5, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@AriParkkila AriParkkila force-pushed the AriParkkila:cell-dns branch from c6acced to e112466 Aug 6, 2019

@AriParkkila

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

Fixed unittests, ready for merge.

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 6, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@SeppoTakalo SeppoTakalo merged commit 976c30c into ARMmbed:master Aug 7, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8705 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.