Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inclusion of test related directories by build tool #11166

Merged
merged 2 commits into from Aug 13, 2019

Conversation

@hugueskamba
Copy link
Contributor

commented Aug 5, 2019

Description

Prevent mbed-os/components/TARGET_PSA/services/attestation/qcbor/test to be included by the build tool during compilation.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@evedon @gpsimenos

@ciarmcom ciarmcom requested review from evedon, gpsimenos and ARMmbed/mbed-os-maintainers Aug 5, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@hugueskamba, thank you for your changes.
@gpsimenos @evedon @ARMmbed/mbed-os-maintainers please review.

@evedon
evedon approved these changes Aug 5, 2019
Copy link
Contributor

left a comment

Looks good to me.

@ARMmbed/mbed-os-tools

@evedon evedon added needs: CI and removed needs: review labels Aug 6, 2019

@evedon

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 6, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 6, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

I restarted events, should be ready for merge soon

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

[Fatal Error] AsyncOp.h@21,19: Mutex.h: No such file or directory

@hugueskamba Please review events failures in the travis. They don't look related. I restarted it to make sure. Not certain how adding test ignore inside cbor could affect building usb files.

@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

[Fatal Error] AsyncOp.h@21,19: Mutex.h: No such file or directory

@hugueskamba Please review events failures in the travis. They don't look related. I restarted it to make sure. Not certain how adding test ignore inside cbor could affect building usb files.

@0xc0170 The failure is not related to this change.
It is happening because mbed-os/drivers/source/usb/ is included in the build but should not because for that particular build mbed-os/rtos is excluded.

@hugueskamba hugueskamba force-pushed the hugueskamba:hk-ignore-test-dirs branch from 26673cb to e507435 Aug 9, 2019

@hugueskamba

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

CI restarted

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

I restarted CI. Travis seems to have a problem with hook update, I restarted it

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Aug 9, 2019

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 9, 2019

Test run: FAILED

Summary: 2 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
  • jenkins-ci/mbed-os-ci_greentea-test
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Waiting for pr-merge fix , cc @ARMmbed/mbed-os-test

Exporters restarted

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 13, 2019

@0xc0170 0xc0170 merged commit 96fbf9d into ARMmbed:master Aug 13, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/jenkins/pr-merge Manually fixed status
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8599 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@hugueskamba hugueskamba deleted the hugueskamba:hk-ignore-test-dirs branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.