Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xpresso: qspi_write fix #11168

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@maciejbocianski
Copy link
Member

commented Aug 6, 2019

Due to the data buffer is loaded in two steps the whole block needs protection from being interrupted to prevent write fails.

Description

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-hal
@mmahadevan108

Release Notes

@ciarmcom ciarmcom requested review from maclobdell and ARMmbed/mbed-os-maintainers Aug 6, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@maciejbocianski, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@mmahadevan108
Copy link
Contributor

left a comment

Thank you very much for the changes, this fixes the issues I am seeing.

Please include the below line to avoid warnings
#include "platform/mbed_critical.h"

Xpresso: qspi_write fix
Due to the data buffer is loaded in two steps the whole block needs protection from being interrupted

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:fix_qspi_write_k82f branch from 95d17a2 to f2599f4 Aug 6, 2019

@maciejbocianski

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

fixed

@0xc0170
0xc0170 approved these changes Aug 8, 2019

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 8, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 8, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit fd931a1 into ARMmbed:master Aug 9, 2019

26 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8631 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8448B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details

@0xc0170 0xc0170 removed the ready for merge label Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.