Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: failure when deleting created context is not considered error #11190

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@jarvte
Copy link
Contributor

commented Aug 9, 2019

Description

If context delete fails there is nothing we or application can do. There is no point
returning an error for this. This affects to CellularContext/AT_CellularContext::disconnect
not returning an error if context delete fails. No need for documentation update.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila

…an error

If delete fails there is nothing we or application can do. There is no point
returning an error for this. This affects to AT_CellularContext::disconnect
not returning an error if context delete fails.
@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers Aug 9, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

Copy link
Member

left a comment

Is this fix for the patch release (changing the return value)?

@ciarmcom ciarmcom requested review from AriParkkila and ARMmbed/mbed-os-maintainers Aug 9, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@jarvte, thank you for your changes.
@AriParkkila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Is this fix for the patch release (changing the return value)?

Not mandatory for the patch release but if this is not too big of a change it would be good to be there. This helps to get rid of the disconnect failures which we or the app can do nothing about and should be very rare.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 12, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter
@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2019

I guess exporter failure is not related to this pr.

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

It's not, Tracking issue for exporters failure: #11209

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 14, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@adbridge adbridge added ready for merge and removed needs: CI labels Aug 15, 2019
@adbridge adbridge merged commit 2af2b1b into ARMmbed:master Aug 15, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/jenkins/pr-merge Manually fixed status
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8681 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@jarvte jarvte deleted the jarvte:fix_wise1570_netsocket_tests branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.