Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: move RAT reading to better support ublox custom boards #11191

Merged
merged 1 commit into from Aug 13, 2019

Conversation

@jarvte
Copy link
Contributor

commented Aug 9, 2019

Description

AT commands used in read_radio_technology() function are not supported
by all boards so moving the function where it's actually used. Usage was
already inside of the #ifdef's.

Fixes the issue #11170

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

AT commands used in read_radio_technology() function are not supported
by all boards so moving the function where it's actually used. Usage was
already inside of the #ifdef's.
@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Aug 9, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@jarvte, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
0xc0170 approved these changes Aug 9, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

CI started

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 9, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 9, 2019

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
@jarvte

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Failed greentea test not related to this pr

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Waiting for pr merge fix from @ARMmbed/mbed-os-test

@0xc0170 0xc0170 merged commit 8767ab4 into ARMmbed:master Aug 13, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/jenkins/pr-merge Manually fixed status
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8584 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@jarvte jarvte deleted the jarvte:fix_ublox_board_support branch Aug 13, 2019
@adbridge

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

This is on top of 5.14 changes so now targeting that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.