Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Fixed improper AT handler setup through virtual calls in co… #11201

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@mirelachirica
Copy link
Contributor

commented Aug 12, 2019

Description

Added AT handler setup method to be used for initialisation routines that are virtual and therefore cannot be called from constructor.
For now it only sets AT send delay and URCs.

Pull request type

[ x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@AriParkkila @jarvte

@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Aug 12, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@mirelachirica, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@jarvte
jarvte approved these changes Aug 12, 2019
UNITTESTS/stubs/ATHandler_stub.cpp Outdated Show resolved Hide resolved
@mirelachirica

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

I dont see the check failure being related to the changes in this PR.

@mirelachirica

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

Can some of the @ARMmbed/mbed-os-maintainers or @ARMmbed/mbed-os-wan review this?

…nstructor

Added AT handler setup method to be used for initialisation routines
that are virtual and therefore cannot be called from constructor.
@mirelachirica mirelachirica force-pushed the mirelachirica:bug_virtual_in_constructor branch from dd9f30d to 75c823c Aug 16, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

CI started

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 19, 2019
@mbed-ci

This comment has been minimized.

Copy link

commented Aug 20, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit b849bc1 into ARMmbed:master Aug 20, 2019
25 checks passed
25 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8712 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@pilotak pilotak referenced this pull request Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.