Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: add nonscannable connectable type #11204

Merged
merged 2 commits into from Aug 20, 2019

Conversation

@paul-szczepanek-arm
Copy link
Member

commented Aug 12, 2019

Description

GAP was missing an advertising type that would allow to attach an extended advertising payload (non-legacy PDU) and also be connectable. This adds this type. This is caused by the limitation where extended pdu cannot be added to advertising that is both scannable and connectable.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@donatieng

Release Notes

Adds new type, existing functionality unchanged.

@ciarmcom ciarmcom requested review from donatieng and ARMmbed/mbed-os-maintainers Aug 12, 2019

@ciarmcom

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

@donatieng
Copy link
Member

left a comment

LGTM thanks @paul-szczepanek-arm

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 14, 2019

@0xc0170

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

commented Aug 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@@ -446,6 +446,9 @@ struct advertising_event_properties_t {
break;
case advertising_type_t::ADV_NONCONN_IND:
break;
case advertising_type_t::ADV_NONSCAN_IND:
connectable = true;

This comment has been minimized.

Copy link
@pan-

pan- Aug 19, 2019

Member

use_legacy_pdu should be set too false.

This comment has been minimized.

Copy link
@paul-szczepanek-arm

paul-szczepanek-arm Aug 19, 2019

Author Member

I assumed it was, seeing as only a few lines above there's a:

 use_legacy_pdu = true;

but apparently the default is already true

This comment has been minimized.

Copy link
@paul-szczepanek-arm

paul-szczepanek-arm Aug 19, 2019

Author Member

Actually the default constructor does set it to false and either way it's irrelevant since the type shouldn't set it as it's set by an explicit passed in parameter.

This comment has been minimized.

Copy link
@paul-szczepanek-arm

paul-szczepanek-arm Aug 19, 2019

Author Member
    pal::advertising_event_properties_t event_properties(params.getType());
    event_properties.use_legacy_pdu = params.getUseLegacyPDU();

This comment has been minimized.

Copy link
@paul-szczepanek-arm

paul-szczepanek-arm Aug 19, 2019

Author Member

We discussed this and the changes required to make this neat are outside of scope for this PR and functionally the code is correct.

@0xc0170 0xc0170 merged commit e4e6c64 into ARMmbed:master Aug 20, 2019

25 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8721 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8464B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.